Skip to content
This repository has been archived by the owner on Nov 14, 2024. It is now read-only.

Remove deprecation until downstream services catch up. #4733

Merged
merged 2 commits into from
Apr 27, 2020

Conversation

jkozlowski
Copy link
Contributor

Goals (and why):

Services running with -Xlint:deprecation will fail merging the version bump, until we have made them switch.

Implementation Description (bullets):

Testing (What was existing testing like? What have you done to improve it?):

Concerns (what feedback would you like?):

Where should we start reviewing?:

Priority (whenever / two weeks / yesterday):

@changelog-app
Copy link

changelog-app bot commented Apr 27, 2020

Generate changelog in changelog/@unreleased

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Remove deprecation on TransactionManagers#runtimeConfigSupplier until downstream services catch up.

Check the box to generate changelog(s)

  • Generate changelog entry

Copy link
Contributor

@jeremyk-91 jeremyk-91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, having people maintain a current version would be more important - it’s a bit crap that it means we can’t (immediately) use the annotation, but oh well

@jkozlowski jkozlowski merged commit 618c241 into develop Apr 27, 2020
@delete-merged-branch delete-merged-branch bot deleted the remove-deprecated branch April 27, 2020 08:30
@svc-autorelease
Copy link
Collaborator

Released 0.211.1

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants