Skip to content
This repository has been archived by the owner on Nov 14, 2024. It is now read-only.

The Wrath of Indonesia: JavaX -> Jakarta Migration #4677

Merged
merged 20 commits into from
Mar 27, 2020
Merged

Conversation

jeremyk-91
Copy link
Contributor

Goals (and why):

  • Get on latest version of conjure-java-runtime

Implementation Description (bullets):

  • Upgrade CJR versions.
  • But this has transitives that break: Tritium and Jersey classes
  • And this has further transitives: Dropwizard and its role in testing
  • And that has a transitive effect: WireMock
  • This PR resolves all of the aforementioned transitives. Thankfully the WireMock folks prepped a fat jar.
  • I validated that we don't have cases where both JavaX and Jakarta things live on the classpath.

Testing (What was existing testing like? What have you done to improve it?):

  • Existing tests, for general integrity of library stack
  • I used baseline-class-uniqueness to validate that no JavaX and Jakarta things simultaneously live on the classpath. I did not leave it there as there were unrelated issues between AssertJ and ByteBuddy that I don't have the bandwidth to resolve right now.

Concerns (what feedback would you like?):

  • While the tests work, I still have a feeling that some of the HTTP stack stuff is risky, especially since we bumped Dropwizard through two major versions. The scary dependency-resolution problems I had would not affect prod code, so I'm a bit less worried, but that's worth validating.

Where should we start reviewing?: versions.props

Priority (whenever / two weeks / yesterday): this week, if not in by tomorrow we should probably go with #4655 first

@changelog-app
Copy link

changelog-app bot commented Mar 26, 2020

Generate changelog in changelog/@unreleased

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Conjure Java Runtime is upgraded to 4.70.1.

Check the box to generate changelog(s)

  • Generate changelog entry

@iamdanfox
Copy link
Contributor

Is there a plan to get onto GCV? having such a long list of forces in versions.props is a little scary :/

@jkozlowski
Copy link
Contributor

I think we should pull this into an internal product to just sanity check it starts up alright?

versions.props Outdated
@@ -43,13 +44,17 @@ io.airlift:airline = 0.8
io.atomix.catalyst:* = 1.1.2
io.atomix.copycat:* = 1.2.0
io.atomix:* = 1.0.0-rc9
io.dropwizard.metrics:metrics-* = 3.2.3
io.dropwizard.metrics:metrics-* = 4.1.5
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this not effectively cause a bump in version for anyone that consumes atlasdb?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it will. I'll see if we can separate the test and compile classpaths.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can't be on dropwizard metrics 4

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it has enough breaking changes here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now we're not. I went back to metrics 3

Copy link
Contributor

@gmaretic gmaretic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving contingent on it working on internal product

@jeremyk-91
Copy link
Contributor Author

Validated on internal ski product in deployment to an internal stack. Pressing the big red button ™️

@jeremyk-91
Copy link
Contributor Author

GCV: I'll open a task for tracking, it's probably worth doing soon. I think it's fair to say someone will look at this in the next 1-2 weeks, though I don't know how deep that rabbithole goes, so I can't commit the team to doing it in that time span.

@jeremyk-91 jeremyk-91 merged commit a8e39bd into develop Mar 27, 2020
@delete-merged-branch delete-merged-branch bot deleted the jkong/jakarta branch March 27, 2020 18:38
@svc-autorelease
Copy link
Collaborator

Released 0.198.7

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants