-
Notifications
You must be signed in to change notification settings - Fork 15
The Wrath of Indonesia: JavaX -> Jakarta Migration #4677
Conversation
Generate changelog in
|
Is there a plan to get onto GCV? having such a long list of forces in versions.props is a little scary :/ |
I think we should pull this into an internal product to just sanity check it starts up alright? |
versions.props
Outdated
@@ -43,13 +44,17 @@ io.airlift:airline = 0.8 | |||
io.atomix.catalyst:* = 1.1.2 | |||
io.atomix.copycat:* = 1.2.0 | |||
io.atomix:* = 1.0.0-rc9 | |||
io.dropwizard.metrics:metrics-* = 3.2.3 | |||
io.dropwizard.metrics:metrics-* = 4.1.5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this not effectively cause a bump in version for anyone that consumes atlasdb?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it will. I'll see if we can separate the test and compile classpaths.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can't be on dropwizard metrics 4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it has enough breaking changes here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now we're not. I went back to metrics 3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving contingent on it working on internal product
Validated on internal ski product in deployment to an internal stack. Pressing the big red button ™️ |
GCV: I'll open a task for tracking, it's probably worth doing soon. I think it's fair to say someone will look at this in the next 1-2 weeks, though I don't know how deep that rabbithole goes, so I can't commit the team to doing it in that time span. |
Released 0.198.7 |
Goals (and why):
Implementation Description (bullets):
Testing (What was existing testing like? What have you done to improve it?):
Concerns (what feedback would you like?):
Where should we start reviewing?: versions.props
Priority (whenever / two weeks / yesterday): this week, if not in by tomorrow we should probably go with #4655 first