Skip to content
This repository has been archived by the owner on Nov 14, 2024. It is now read-only.

[Large Internal Product] Oracle config builders must be public #4640

Merged
merged 2 commits into from
Mar 5, 2020
Merged

[Large Internal Product] Oracle config builders must be public #4640

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
53ef603
careless with abstract classes
jeremyk-91 Mar 5, 2020
489a430
Add generated changelog entries
jeremyk-91 Mar 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...-dbkvs-hikari/src/main/java/com/palantir/nexus/db/pool/config/OracleConnectionConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,10 +222,10 @@ private String connectionDataString() {
+ " One needs to be specified.");
}

static class Builder extends ImmutableOracleConnectionConfig.Builder {}
public static class Builder extends ImmutableOracleConnectionConfig.Builder {}

@Value.Immutable
interface ServiceNameConfiguration {
public interface ServiceNameConfiguration {
String serviceName();
String namespaceOverride();

Expand Down
5 changes: 5 additions & 0 deletions changelog/@unreleased/pr-4640.v2.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
type: fix
fix:
description: Fix bug that prevented programmatic creation of Oracle connection configuration.
links:
- https://github.com/palantir/atlasdb/pull/4640