This repository has been archived by the owner on Nov 14, 2024. It is now read-only.
Fix coalescing supplier #4541
Merged
Fix coalescing supplier #4541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let's just take out a lock - and write a test that covers it. It's more obviously correct.
Generate changelog in
|
j-baker
commented
Jan 28, 2020
| future.complete(delegate.get()); | ||
| } catch (Throwable t) { | ||
| future.completeExceptionally(t); | ||
| synchronized (lock) { |
There was a problem hiding this comment.
this is an uncontended lock except in the case of the bug.
j-baker
force-pushed
the
jbaker/coalescing_supplier_fix
branch
from
e96a501 to
d9ae980
Compare
jeremyk-91
reviewed
Jan 28, 2020
gmaretic
approved these changes
Jan 28, 2020
| return counter.incrementAndGet(); | ||
| }); | ||
| List<ListenableFuture<?>> futures = IntStream.range(0, poolSize) | ||
| .mapToObj(index -> executorService.submit(() -> assertIncreasing(supplier))) |
|
Released 0.185.3 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's just take out a lock - and write a test that covers it. It's more
obviously correct.