This repository has been archived by the owner on Nov 14, 2024. It is now read-only.
reduce sweep queue logspam for short-lived write-heavy tables #4456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's bad mostly because it emits a log per batch, instead of something halfway reasonable like emitting the log per deleted table.
Generate changelog in
|
clockfort
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing code is bad mostly because it emits a log per batch, instead of something
halfway reasonable like emitting the log per deleted table.
Low sweep queue batch sizes along with short-lived, heavily mutated groups of tables is probably the worst case scenario, which we had on our stack. The service creates a decent number of tables (~10-20), does a data import and manipulation into them (performs lots of writes, including to the sweep queue), and then upon completion drops the tables.
Having every batch of the sweep queue afterwards log about these tables proved to be very logspammy.