[PDS-10{3841,4895}] Part 1: Revert Automated Stream Store Cleanup

[jeremyk-91]

Goals (and why):

• Revert Stream Store Metadata Cleanup Task Recovery #4201: we have not been able to pin down why Stream Store Metadata Cleanup Task Recovery #4201 was problematic, and to be clear we aren't necessarily sure that it is broken in the first place. However, it correlates too well with the issues in this ticket's header, so reverting as part of safety.

Implementation Description (bullets):

• Update generated code

Testing (What was existing testing like? What have you done to improve it?):

• Updated stream test to verify that these streams are not cleaned up.

Concerns (what feedback would you like?):

• Is the revert safe?
• Are there edge cases in the stream store code I might have missed out on?

Where should we start reviewing?: StreamStoreRenderer

Priority (whenever / two weeks / yesterday): yesterday 🔥

[changelog-app]

Generate changelog in changelog/@unreleased

Type

• Feature
• Improvement
• Fix
• Break
• Deprecation
• Manual task
• Migration

Description

Stream stores now no longer automatically clean up streams that were stored but never marked as used. We have noticed an increasing incidence of said cleaning being more aggressive than we anticipated.

Users that use stream stores must regenerate their schemas as part of upgrading to this version.

Check the box to generate changelog(s)

• Generate changelog entry

[felixdesouza]

should we revert this and mark this as @Ignore