Skip to content
This repository has been archived by the owner on Nov 14, 2024. It is now read-only.

Remove populateIoCacheOnFlush from TableCreator #4422

Merged
merged 4 commits into from
Nov 20, 2019

Conversation

leonz
Copy link
Contributor

@leonz leonz commented Nov 18, 2019

Goals (and why):
I missed this reference in #4396.

This flag is a no-op in Cassandra 2.1+.

Implementation Description (bullets):

Testing (What was existing testing like? What have you done to improve it?):

Concerns (what feedback would you like?):

Where should we start reviewing?:

Priority (whenever / two weeks / yesterday):

@changelog-app
Copy link

changelog-app bot commented Nov 18, 2019

Generate changelog in changelog/@unreleased

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Remove the populateIoCacheOnFlush field from the CassandraTableCreator.

Check the box to generate changelog(s)

  • Generate changelog entry

@leonz leonz requested a review from jeremyk-91 November 18, 2019 23:11
Copy link
Contributor

@jeremyk-91 jeremyk-91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, makes sense.

@felixdesouza
Copy link
Contributor

I've fixed the build, are you able to rebase please? then we can get this in

@leonz leonz force-pushed the leonz/remove-populateiocache branch from 6d86615 to 343e715 Compare November 19, 2019 16:49
@leonz
Copy link
Contributor Author

leonz commented Nov 19, 2019

Rebased

@leonz
Copy link
Contributor Author

leonz commented Nov 19, 2019

@felixdesouza still failing unfortunately

@OStevan OStevan force-pushed the leonz/remove-populateiocache branch from 343e715 to 4ad4882 Compare November 20, 2019 14:51
@felixdesouza felixdesouza merged commit 4e78280 into develop Nov 20, 2019
@delete-merged-branch delete-merged-branch bot deleted the leonz/remove-populateiocache branch November 20, 2019 15:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants