This repository has been archived by the owner on Nov 14, 2024. It is now read-only.
upgrade HikariCP [2.4.7 -> 3.4.1] #4421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
jeremyk-91
approved these changes
Nov 19, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background:
Judging from some of the hikari github issues with similar errors to ours, this might resolve an issue we're seeing around excessive errors when hikari tries to double-close already closed connections (perhaps due to DB-side timeouts / poor customer DB configuration or network)
Issues:
The 2.x --> 3.x bump does remove some API bits that downstream project touches, but the fixes are easy and I can do them.
The metrics hikari produces also got a bunch of changes, mostly additions, but some small changes that may break the dashboards that use them. I own the downstream dashboard and can fix.