[Conjure Java Runtime] Part 16: Revising Project Paths, Fix FastFailoverProxy

[jeremyk-91]

IMPORTANT NOTE TO REVIEWERS: Unlike in many other PRs, in this PR the movement of files is a considerable part of the PR. Please read carefully and check that those movements make sense. Thanks!

a.k.a. Fix FastFailoverProxy from fogging fanciness and fragment Feign folder for favorable future functioning.

Goals (and why):

• Structure dependencies in a clear, unambiguous way. This also avoids some conceptual problems later on, where atlasdb-conjure code expects a shaded feign.RetryableException but receives an unshaded one.

Implementation Description (bullets):

• Implement two new projects atlasdb-remoting-api and atlasdb-conjure.

Testing (What was existing testing like? What have you done to improve it?):

• The tests still work in the new projects, and integration tests should check the visibility of everything.

Concerns (what feedback would you like?):

• I shoved PollingRefreshable into atlasdb-remoting-api, which is a bit sad because it requires a dependency on commons-executors. Not a perfect fit but I felt making another atlasdb-remoting-impl-shared project was a bit overkill.

Where should we start reviewing?:

• build.gradles of the two projects.

Priority (whenever / two weeks / yesterday): today or tomorrow?

[changelog-app]

Generate changelog in changelog/@unreleased

Type

• Feature
• Improvement
• Fix
• Break
• Deprecation
• Manual task
• Migration

Description

FastFailoverProxy now correctly identifies retryable exceptions and deals with them. Previously, the proxy would expect a shaded retryable exception, when the exceptions it received would have been unshaded as they would have originated from TimeLock and thus external to the atlasdb-feign client project.

Check the box to generate changelog(s)

• Generate changelog entry

[gmaretic]

Sadness is sad

[gmaretic]

Remove from gradle/versions.gradle and update timestamp-impl?

[jeremyk-91]

Will do

[svc-autorelease]

Released 0.169.0