This repository has been archived by the owner on Nov 14, 2024. It is now read-only.
make user agent required #2542
Merged
make user agent required #2542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #2542 +/- ##
============================================
- Coverage 60.02% 60% -0.02%
+ Complexity 4659 4042 -617
============================================
Files 860 860
Lines 40121 40112 -9
Branches 4070 4070
============================================
- Hits 24081 24069 -12
- Misses 14572 14573 +1
- Partials 1468 1470 +2
Continue to review full report at Codecov.
|
hsaraogi
approved these changes
Oct 23, 2017
atlasdb-config/readme.md
Outdated
| @@ -48,6 +49,7 @@ public void run(AtlasDbServerConfiguration config, Environment env) throws Excep | |||
| TransactionManager transactionManager = TransactionManagers.builder() | |||
| .config(config.getAtlas()) | |||
| .registrar(env.jersey()::register) | |||
| .userAgent("user agent") | |||
There was a problem hiding this comment.
Dont we expect products to set useragent as UserAgents.fromStrings("productName", "productVersion") ? Might be a good idea to document that or we will end up with just "productName"s as useragents.
There was a problem hiding this comment.
witchcraft will auto-gen the user agent for you, but yea I can update for general best practice.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals (and why): Resolves #2528
Implementation Description (bullets): Require the previously optional
userAgentmethod in theTransactionManagersbuilder. Remove thecallingClassoption.Concerns (what feedback would you like?): Technically this is a breaking change, but we only just introduced this API last release and I doubt anyone is using yet. And either way people really should be doing this no matter what. The old
createmethods still exist and are still deprecated.Where should we start reviewing?:
TransactionManagersPriority (whenever / two weeks / yesterday):
This change is