Skip to content
This repository has been archived by the owner on Nov 14, 2024. It is now read-only.

Increase Cell Ts pairs to 1024 #2507

Merged
merged 2 commits into from
Oct 18, 2017
Merged

Increase Cell Ts pairs to 1024 #2507

merged 2 commits into from
Oct 18, 2017

Conversation

hsaraogi
Copy link
Contributor

@hsaraogi hsaraogi commented Oct 18, 2017

Goals (and why): After the sweep rewrite we can sweep faster without causing C* OOMs.

Implementation Description (bullets): bump the config value

Concerns (what feedback would you like?): Should we test on internal fruity deployment before rolling out widely? can this be 100k?

Where should we start reviewing?: one file

Priority (whenever / two weeks / yesterday): soon


This change is Reviewable

@hsaraogi hsaraogi force-pushed the bump-sweep-batch-size branch from f474a0f to e0789e2 Compare October 18, 2017 10:28
Copy link
Contributor

@gsheasby gsheasby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a little on the conservative side, but should be ok to start. We should test higher values (100k? 1 million?) on individual deployments that don't have strict uptime requirements. If that goes smoothly, we can bump the hint again.

@codecov-io
Copy link

codecov-io commented Oct 18, 2017

Codecov Report

Merging #2507 into develop will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             develop   #2507      +/-   ##
============================================
- Coverage      60.15%   60.1%   -0.06%     
+ Complexity      4649    3385    -1264     
============================================
  Files            859     859              
  Lines          40030   40030              
  Branches        4076    4076              
============================================
- Hits           24081   24059      -22     
- Misses         14481   14504      +23     
+ Partials        1468    1467       -1
Impacted Files Coverage Δ Complexity Δ
...in/java/com/palantir/atlasdb/AtlasDbConstants.java 90.47% <ø> (ø) 1 <0> (ø) ⬇️
...ain/java/com/palantir/paxos/PaxosQuorumStatus.java 77.77% <0%> (-11.12%) 0% <0%> (ø)
...ain/java/com/palantir/leader/LeadershipEvents.java 83.33% <0%> (-8.34%) 0% <0%> (ø)
...lasdb/keyvalue/impl/SweepStatsKeyValueService.java 72.41% <0%> (-6.04%) 19% <0%> (-1%)
...ain/java/com/palantir/paxos/PaxosAcceptorImpl.java 73.21% <0%> (-5.36%) 0% <0%> (ø)
.../palantir/atlasdb/sweep/BackgroundSweeperImpl.java 77.22% <0%> (-2.98%) 0% <0%> (-16%)
...main/java/com/palantir/paxos/PaxosLearnerImpl.java 87.8% <0%> (-2.44%) 0% <0%> (ø)
...om/palantir/leader/PaxosLeaderElectionService.java 79.44% <0%> (-1.12%) 0% <0%> (ø)
...tion/impl/AbstractSerializableTransactionTest.java 85.2% <0%> (-1.1%) 34% <0%> (ø)
...n/java/com/palantir/lock/impl/LockServiceImpl.java 83.3% <0%> (+0.35%) 91% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13a2b81...d209d7f. Read the comment docs.

@gsheasby gsheasby changed the title Increase Cell Ts pairs to 10k Increase Cell Ts pairs to 1024 Oct 18, 2017
@gsheasby gsheasby merged commit 5868f2a into develop Oct 18, 2017
@gsheasby gsheasby deleted the bump-sweep-batch-size branch October 18, 2017 11:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants