This repository has been archived by the owner on Nov 14, 2024. It is now read-only.
deprecate old executor usage; allow for specifying your own #2457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tpetracca
commented
Oct 10, 2017
| } | ||
|
|
||
| public LockRefreshingTimelockService(TimelockService delegate, LockRefresher lockRefresher) { | ||
| @VisibleForTesting | ||
| LockRefreshingTimelockService( |
There was a problem hiding this comment.
this is technically an API break as it's no longer public, but I think that's fine?
ashrayjain
reviewed
Oct 10, 2017
| @@ -29,7 +29,7 @@ | |||
| import com.palantir.lock.v2.LockToken; | |||
| import com.palantir.lock.v2.TimelockService; | |||
|
|
|||
| public class LockRefresher implements AutoCloseable { | |||
| public class LockRefresher { | |||
There was a problem hiding this comment.
Isn't this an api break?
There was a problem hiding this comment.
depends when it gets merged... I added it in yesterday
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals (and why): Move to supplying your own executor, per #2451 (comment)
Implementation Description (bullets):
Concerns (what feedback would you like?):
Where should we start reviewing?:
Priority (whenever / two weeks / yesterday):
This change is