This repository has been archived by the owner on Nov 14, 2024. It is now read-only.
Actually log batch parameters in BackgroundSweeperImpl and friends #2444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hsaraogi
approved these changes
Oct 6, 2017
tpetracca
suggested changes
Oct 6, 2017
| @@ -150,7 +150,9 @@ private long grabLocksAndRun(SweepLocks locks) throws InterruptedException { | |||
| SweepBatchConfig lastBatchConfig = getAdjustedBatchConfig(); | |||
| log.warn("The background sweep job failed unexpectedly with batch config {}." | |||
There was a problem hiding this comment.
doesn't this line and the number of {} need to have an equivalent change?
There was a problem hiding this comment.
Yep, of course. I think I got too excited when I saw that the json params were logged correctly...
Codecov Report
@@ Coverage Diff @@
## develop #2444 +/- ##
=============================================
- Coverage 60.09% 60.08% -0.02%
+ Complexity 4522 3213 -1309
=============================================
Files 833 833
Lines 39414 39395 -19
Branches 4037 4036 -1
=============================================
- Hits 23687 23671 -16
+ Misses 14253 14250 -3
Partials 1474 1474
Continue to review full report at Codecov.
|
|
Closing in favor of #2475. |
fsamuel-bs
added a commit
that referenced
this pull request
Oct 17, 2017
* Better logging for internal customer * Update docs * Copy over #2444
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals (and why):
{}. This fixes that and returns the three values (candidate batch size, delete batch size, max no. of cell-ts pairs to examine)Implementation Description (bullets):
Concerns (what feedback would you like?):
Where should we start reviewing?: BackgroundSweeperImpl
Priority (whenever / two weeks / yesterday): soon, please - makes debugging sweep by sniffing its logs very hard
This change is