This repository has been archived by the owner on Nov 14, 2024. It is now read-only.
Upgrade to newer Awaitility. #2429
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tpetracca
approved these changes
Oct 5, 2017
hsaraogi
reviewed
Oct 18, 2017
| @@ -146,7 +146,7 @@ | |||
| public void setup() throws JsonProcessingException { | |||
| // Change code to run synchronously, but with a timeout in case something's gone horribly wrong | |||
| originalAsyncMethod = TransactionManagers.runAsync; | |||
| TransactionManagers.runAsync = task -> Awaitility.await().atMost(2, TimeUnit.SECONDS).until(task); | |||
| TransactionManagers.runAsync = task -> Awaitility.await().atMost(2, TimeUnit.SECONDS).untilAsserted(task::run); | |||
There was a problem hiding this comment.
task is a Runnable I believe, why did we change this to task::run?
| @@ -9,7 +9,7 @@ com.google.dagger:dagger = 2.0.2 | |||
| com.google.dagger:dagger-compiler = 2.0.2 | |||
| com.google.guava:* = 18.0 | |||
| com.googlecode.json-simple:json-simple = 1.1.1 | |||
| com.jayway.awaitility:awaitility = 1.6.5 | |||
There was a problem hiding this comment.
Looked through the release notes, https://github.com/awaitility/awaitility/wiki/ReleaseNotes30. The changes make sense. Thanks for the contribution!
Merged
|
Closing in favor of #2668. |
|
Whoops, I somehow missed that there had been responses. task is indeed Runnable, but untilAsserted demands a ThrowingRunnable. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals (and why):
Implementation Description (bullets):
Concerns (what feedback would you like?):
Where should we start reviewing?:
Priority (whenever / two weeks / yesterday):
This change is