Skip to content
This repository has been archived by the owner on Nov 14, 2024. It is now read-only.

Include 0.59.1 in release notes #2425

Merged
merged 4 commits into from
Oct 4, 2017
Merged

Conversation

gmaretic
Copy link
Contributor

@gmaretic gmaretic commented Oct 4, 2017

Goals (and why):
Consistent release notes

Priority (whenever / two weeks / yesterday):
When you get the chance


This change is Reviewable

amerguy and others added 4 commits October 4, 2017 17:49
* Adding an optional ProxyConfiguration to TimelockConfigs to allow for custom proxy selector

* Marking functions as deprecated and add new APIs seperately to avoid breaking changes

* adding release notes

* doc indentation

* checkstyle

* Javadocs: link to recommended methods

* add link to proxyConfig

* fix bad merge on release notes

* releasenotes fix

* add test for setting proxy config

* add proxy tests

* lowercase

* getHostAndPort for ProxyConfig

* whitespace

* fixing test
@gmaretic gmaretic requested a review from fsamuel-bs October 4, 2017 17:02
@codecov-io
Copy link

Codecov Report

Merging #2425 into develop will increase coverage by 0.04%.
The diff coverage is 58.33%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2425      +/-   ##
=============================================
+ Coverage      60.28%   60.33%   +0.04%     
+ Complexity      4035     4033       -2     
=============================================
  Files            829      826       -3     
  Lines          39125    39074      -51     
  Branches        4019     4014       -5     
=============================================
- Hits           23587    23575      -12     
+ Misses         14067    14031      -36     
+ Partials        1471     1468       -3
Impacted Files Coverage Δ Complexity Δ
...lantir/atlasdb/http/AtlasDbFeignTargetFactory.java 0% <0%> (ø) 0 <0> (ø) ⬇️
.../java/com/palantir/atlasdb/http/TimelockUtils.java 0% <0%> (ø) 0 <0> (ø) ⬇️
.../com/palantir/atlasdb/http/FeignOkHttpClients.java 61.53% <50%> (ø) 0 <0> (ø) ⬇️
.../com/palantir/atlasdb/http/AtlasDbHttpClients.java 65.21% <60%> (ø) 4 <0> (ø) ⬇️
...a/com/palantir/atlasdb/factory/ServiceCreator.java 85.71% <76.92%> (ø) 1 <0> (ø) ⬇️
...ntir/atlasdb/keyvalue/jdbc/JdbcAtlasDbFactory.java 0% <0%> (-22.23%) 0% <0%> (-2%)
...tlasdb/keyvalue/dbkvs/DbKeyValueServiceConfig.java 85.71% <0%> (-14.29%) 4% <0%> (-1%)
...antir/atlasdb/keyvalue/dbkvs/DbAtlasDbFactory.java 0% <0%> (-13.34%) 0% <0%> (-2%)
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b51510...9b9c6cd. Read the comment docs.

Copy link
Contributor

@fsamuel-bs fsamuel-bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants