[Exclusions] Missing fail is a fail (#5518)

* missing fail * welp
palantir · Jun 25, 2021 · aefcdac · aefcdac
1 parent 09c1776
commit aefcdac
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 8 deletions.
diff --git a/build.gradle b/build.gradle
@@ -134,7 +134,6 @@ allprojects {
                 'JdkObsolete',
                 'LogSafePreconditionsMessageFormat',
                 'MathAbsoluteRandom',
-                'MissingFail',
                 'MissingSummary',
                 'MixedMutabilityReturnType',
                 'MockitoInternalUsage',

diff --git a/lock-impl/src/test/java/com/palantir/lock/impl/ClientAwareLockTest.java b/lock-impl/src/test/java/com/palantir/lock/impl/ClientAwareLockTest.java
@@ -176,11 +176,7 @@ public void testTimedTryLockCanFail() throws Exception {
             assertThat(anonymousReadLock.tryLock()).isNotNull();
             anonymousReadLock.lock();
         });
-        try {
-            future2.get(10, TimeUnit.MILLISECONDS);
-        } catch (TimeoutException expected) {
-            /* Expected. */
-        }
+        assertThatThrownBy(() -> future2.get(10, TimeUnit.MILLISECONDS)).isInstanceOf(TimeoutException.class);
         future1.get(200, TimeUnit.MILLISECONDS);
         future2.get(10, TimeUnit.MILLISECONDS);
     }

diff --git a/lock-impl/src/test/java/com/palantir/lock/impl/ThreadPooledWrapperTest.java b/lock-impl/src/test/java/com/palantir/lock/impl/ThreadPooledWrapperTest.java
@@ -197,8 +197,8 @@ private void assertBlockedThreadsAreDone(List<Future> futures, int numberBlocked
         assertThat(exceptions.get()).isEqualTo(numberBlocked);
     }
 
-    private void assertSuccessfulThreadsAreDone(List<Future> futures, int numberSuccessful)
-            throws InterruptedException, ExecutionException {
+    @SuppressWarnings("MissingFail") // This method *counts* successes and expects *some* to work
+    private void assertSuccessfulThreadsAreDone(List<Future> futures, int numberSuccessful) {
         AtomicInteger successes = new AtomicInteger(0);
         futures.forEach(future -> {
             try {