Skip to content
This repository has been archived by the owner on Nov 14, 2024. It is now read-only.

Commit

Permalink
[PD$-110002] Part 3: Remove transactionsReadFromDB (#4838)
Browse files Browse the repository at this point in the history
* Make transactionsReadFromDb a counter

* Actually, remove it

* Add generated changelog entries

* Remove unused constant
  • Loading branch information
jeremyk-91 authored Jun 17, 2020
1 parent d1eb4e5 commit 8fb0f21
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ private CellFilterMetrics() {
public static final String SNAPSHOT_TRANSACTION_CELLS_RETURNED = "numCellsReturnedAfterFiltering";
public static final String SNAPSHOT_TRANSACTION_TOO_MANY_BYTES_READ = "tooManyBytesRead";
public static final String SNAPSHOT_TRANSACTION_BYTES_WRITTEN = "bytesWritten";
public static final String NUMBER_OF_TRANSACTIONS_READ_FROM_DB = "transactionsReadFromDB";

public static final String CELLS_EXAMINED = "cellTimestampPairsExamined";
public static final String CELLS_SWEPT = "staleValuesDeleted";
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2246,8 +2246,6 @@ protected ListenableFuture<Map<Long, Long>> getCommitTimestamps(
logLargeNumberOfTransactions(tableRef, gets);
}

getHistogram(AtlasDbMetricNames.NUMBER_OF_TRANSACTIONS_READ_FROM_DB, tableRef).update(gets.size());

return Futures.transform(loadCommitTimestamps(asyncTransactionService, gets),
rawResults -> {
for (Map.Entry<Long, Long> e : rawResults.entrySet()) {
Expand Down
9 changes: 9 additions & 0 deletions changelog/@unreleased/pr-4838.v2.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
type: improvement
improvement:
description: 'AtlasDB no longer publishes `transactionsReadFromDB`: it was a high
cardinality metric of limited value. Consider using `TransactionService.get` if
attempting to determine the total number of start-commit timestamp mappings looked
up from the transactions tables. Otherwise, consider enabling TRACE logging to
get this data.'
links:
- https://github.com/palantir/atlasdb/pull/4838

0 comments on commit 8fb0f21

Please sign in to comment.