CR comments part 1

palantir · Nov 10, 2017 · 64a7b56 · 64a7b56
1 parent 07b08e0
commit 64a7b56
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 4 deletions.
diff --git a/atlasdb-config/src/main/java/com/palantir/atlasdb/config/AtlasDbRuntimeConfig.java b/atlasdb-config/src/main/java/com/palantir/atlasdb/config/AtlasDbRuntimeConfig.java
@@ -66,7 +66,6 @@ public long getTimestampCacheSize() {
      * This value is ignored if the install config does not specify usage of TimeLock.
      * We do not currently support live reloading from a leader block or using embedded services to using TimeLock.
      */
-
     public abstract Optional<TimeLockRuntimeConfig> timelockRuntime();
 
     public static ImmutableAtlasDbRuntimeConfig defaultRuntimeConfig() {

diff --git a/atlasdb-config/src/main/java/com/palantir/atlasdb/config/TimeLockClientConfigs.java b/atlasdb-config/src/main/java/com/palantir/atlasdb/config/TimeLockClientConfigs.java
@@ -27,5 +27,4 @@ public static TimeLockClientConfig copyWithClient(TimeLockClientConfig config, S
                 .client(namespace)
                 .build();
     }
-
 }
diff --git a/atlasdb-config/src/main/java/com/palantir/atlasdb/http/AtlasDbHttpClients.java b/atlasdb-config/src/main/java/com/palantir/atlasdb/http/AtlasDbHttpClients.java
@@ -156,7 +156,7 @@ public static <T> T createProxyWithFailover(
             String userAgent) {
         return AtlasDbMetrics.instrument(
                 type,
-                AtlasDbFeignTargetFactory.createProxyWithFailover(
+                AtlasDbFeignTargetFactory.createLiveReloadingProxyWithFailover(
                         serverListConfigSupplier, sslSocketFactoryCreator, proxySelectorCreator, type, userAgent),
                 MetricRegistry.name(type));
     }

diff --git a/atlasdb-feign/src/main/java/com/palantir/atlasdb/http/AtlasDbFeignTargetFactory.java b/atlasdb-feign/src/main/java/com/palantir/atlasdb/http/AtlasDbFeignTargetFactory.java
@@ -123,7 +123,7 @@ public static <T> T createProxyWithFailover(
                 userAgent);
     }
 
-    public static <T> T createProxyWithFailover(
+    public static <T> T createLiveReloadingProxyWithFailover(
             Supplier<ServerListConfig> serverListConfigSupplier,
             Function<SslConfiguration, SSLSocketFactory> sslSocketFactoryCreator,
             Function<ProxyConfiguration, ProxySelector> proxySelectorCreator,
-Original file line number
+Diff line change
@@ Expand Up @@
                     .client(namespace)
                     .build();
         }
     }