[PDS-127121] Log refreshed Cassandra hosts at info level (#4917)

* set debug logging to info * Add generated changelog entries * factor out log method * make method static
palantir · Jul 28, 2020 · 52e8a91 · 52e8a91
1 parent c29a52f
commit 52e8a91
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 3 deletions.
diff --git a/...sandra/src/main/java/com/palantir/atlasdb/keyvalue/cassandra/CassandraClientPoolImpl.java b/...sandra/src/main/java/com/palantir/atlasdb/keyvalue/cassandra/CassandraClientPoolImpl.java
@@ -312,9 +312,17 @@ private void setServersInPoolTo(Set<InetSocketAddress> desiredServers) {
             cassandra.refreshTokenRangesAndGetServers();
         }
 
-        log.debug("Cassandra pool refresh added hosts {}, removed hosts {}.",
-                SafeArg.of("serversToAdd", CassandraLogHelper.collectionOfHosts(serversToAdd)),
-                SafeArg.of("serversToRemove", CassandraLogHelper.collectionOfHosts(serversToRemove)));
+        logRefreshedHosts(serversToAdd, serversToRemove);
+    }
+
+    private static void logRefreshedHosts(Set<InetSocketAddress> serversToAdd, Set<InetSocketAddress> serversToRemove) {
+        if (serversToRemove.isEmpty() && serversToAdd.isEmpty()) {
+            log.debug("No hosts added or removed during Cassandra pool refresh");
+        } else {
+            log.info("Cassandra pool refresh added hosts {}, removed hosts {}.",
+                    SafeArg.of("serversToAdd", CassandraLogHelper.collectionOfHosts(serversToAdd)),
+                    SafeArg.of("serversToRemove", CassandraLogHelper.collectionOfHosts(serversToRemove)));
+        }
     }
 
     private Set<InetSocketAddress> getCachedServers() {

diff --git a/changelog/@unreleased/pr-4917.v2.yml b/changelog/@unreleased/pr-4917.v2.yml
@@ -0,0 +1,5 @@
+type: improvement
+improvement:
+  description: Log refreshed Cassandra hosts at info level instead of debug.
+  links:
+  - https://github.com/palantir/atlasdb/pull/4917