Skip to content
This repository has been archived by the owner on Nov 14, 2024. It is now read-only.

Commit

Permalink
Fix deserialization issue. (#4795)
Browse files Browse the repository at this point in the history
* Previous released broke the API under the assumption that we were always sending Optional.empty before.
* But then we pushed the wrong version, so pushing an Optional.of.
  • Loading branch information
jkozlowski authored May 22, 2020
1 parent 0e1a2fd commit 154163a
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 2 deletions.
6 changes: 6 additions & 0 deletions changelog/@unreleased/pr-4795.v2.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
type: improvement
improvement:
description: |-
Fix deserialization issue.
links:
- https://github.com/palantir/atlasdb/pull/4795
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@
public class NoOpLockWatchEventCache implements LockWatchEventCache {
public static final LockWatchEventCache INSTANCE = new NoOpLockWatchEventCache();
private static final IdentifiedVersion FAKE = ImmutableIdentifiedVersion.of(UUID.randomUUID(), 0L);
private static final Optional<IdentifiedVersion> FAKE_OPTIONAL_VERSION = Optional.of(FAKE);
private static final TransactionsLockWatchEvents NONE = TransactionsLockWatchEvents.failure(
LockWatchStateUpdate.snapshot(UUID.randomUUID(), -1L, ImmutableSet.of(), ImmutableSet.of()));

Expand All @@ -36,7 +35,7 @@ private NoOpLockWatchEventCache() {

@Override
public Optional<IdentifiedVersion> lastKnownVersion() {
return FAKE_OPTIONAL_VERSION;
return Optional.empty();
}

@Override
Expand Down

0 comments on commit 154163a

Please sign in to comment.