Moving stacks under the stacks directory #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pacostas
force-pushed
the
moving-stacks-to-stacks
branch
from
c834438
to
7802367
Compare
|
The create-release workflow works. I have a suspicion that the push image workflow does not work so this PR is not ready to be merged. |
|
@mhdawson Tested it, is good to be Reviewed/merged |
mhdawson
reviewed
Sep 20, 2024
| build-java-21/ | ||
| stack/images.json | ||
| builds/ | ||
| stacks/stack/images.json |
There was a problem hiding this comment.
I'm thinking that since we now have the stacks directory it would makes sense for images.json to be in stacks/images.json as opposed to nested into one of the directories is specific to a stack? Maybe I'm forgetting some reason that won't work?
There was a problem hiding this comment.
Makes sense, moved it and tested it. Works. Thank you
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR moves all the stacks under the stacks directory. In the future we might have more than 40 stacks on the root directory.
Use Cases
Checklist