Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #481: Rely on JRE_HOME for Java location #484

Merged
merged 1 commit into from
May 23, 2024
Merged

Conversation

anthonydahanne
Copy link
Member

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@anthonydahanne anthonydahanne requested a review from a team as a code owner May 23, 2024 15:26
@anthonydahanne anthonydahanne added type:bug A general bug semver:patch A change requiring a patch version bump labels May 23, 2024
* JRE_HOME is now set in libjvm, see paketo-buildpacks/libjvm#395
* thanks to that, we know for sure that the JRE_HOME/bin/java will be used for the training run
@anthonydahanne anthonydahanne merged commit 6b7008c into main May 23, 2024
5 checks passed
@anthonydahanne anthonydahanne deleted the fix-481 branch May 23, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:patch A change requiring a patch version bump type:bug A general bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants