-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add liberty action #573
Merged
dmikusa
merged 3 commits into
paketo-buildpacks:main
from
kevin-ortega:addlibertyaction
Feb 25, 2022
Merged
add liberty action #573
dmikusa
merged 3 commits into
paketo-buildpacks:main
from
kevin-ortega:addlibertyaction
Feb 25, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmikusa
added
semver:minor
A change requiring a minor version bump
type:enhancement
A general enhancement
labels
Feb 24, 2022
dmikusa
requested changes
Feb 24, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just that one minor issue. Thanks!
Co-authored-by: Daniel Mikusa <[email protected]>
dmikusa
approved these changes
Feb 25, 2022
This was referenced Mar 10, 2022
This was referenced Mar 10, 2022
This was referenced Mar 11, 2022
This was referenced Mar 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Create custom action for the liberty buildpack to change how versions are handled. The action was copied from the maven-dependency action.
Use Cases
The liberty versions are like, 22.0.0.2 and doesn't conform to the standard semver. Liberty is on a 4-week delivery cycle that increments the last number. The first number is the year. The current generic maven action smushes the version to 22.0.0. This custom builder smushes it to 22.0.2. This change will allow the buildpack to have multiple versions.
Checklist