Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add liberty action #573

Merged
merged 3 commits into from
Feb 25, 2022
Merged

Conversation

kevin-ortega
Copy link
Contributor

Summary

Create custom action for the liberty buildpack to change how versions are handled. The action was copied from the maven-dependency action.

Use Cases

The liberty versions are like, 22.0.0.2 and doesn't conform to the standard semver. Liberty is on a 4-week delivery cycle that increments the last number. The first number is the year. The current generic maven action smushes the version to 22.0.0. This custom builder smushes it to 22.0.2. This change will allow the buildpack to have multiple versions.

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@kevin-ortega kevin-ortega requested a review from a team February 24, 2022 20:25
@dmikusa dmikusa added semver:minor A change requiring a minor version bump type:enhancement A general enhancement labels Feb 24, 2022
Copy link
Contributor

@dmikusa dmikusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just that one minor issue. Thanks!

actions/liberty-dependency/main.go Show resolved Hide resolved
@kevin-ortega kevin-ortega requested a review from dmikusa February 24, 2022 23:14
@dmikusa dmikusa merged commit 45c8e22 into paketo-buildpacks:main Feb 25, 2022
This was referenced Mar 10, 2022
This was referenced Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:minor A change requiring a minor version bump type:enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants