Set a different buildpack id, if necessary #403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most buildpacks have a buildpack id that can be extracted from the package id. For example `gcr.io/paketo-buildpacks/bellsoft-liberica` has a buildpack id of `paketo-buildpacks/bellsoft-liberica`. This doesn't have to be the case though. It is possible for the package id to be something like `gcr.io/my-buildpacks/bellsoft-liberica` but the buildpack id is still `paketo-buildpacks/bellsoft-liberica`, like if you are making your own custom packages of a buildpack. In this case, to find the correct buildpack id the code will take the laste part of the package id, i.e. `bellsoft-liberica` and the indicated version, look through buildpack.toml and see if there is a match where some buildpack id ends with last part of the package id and has a matching version. If it locates a fuzzy match, the well use that id. If not, it fails. Signed-off-by: Daniel Mikusa <[email protected]>
dmikusa
added
type:bug
This was referenced Oct 7, 2021
This was referenced Oct 7, 2021
This was referenced Oct 8, 2021
This was referenced Oct 8, 2021
This was referenced Oct 17, 2021
This was referenced Oct 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Most buildpacks have a buildpack id that can be extracted from the package id. For example
gcr.io/paketo-buildpacks/bellsoft-libericahas a buildpack id ofpaketo-buildpacks/bellsoft-liberica. This doesn't have to be the case though.It is possible for the package id to be something like
gcr.io/my-buildpacks/bellsoft-libericabut the buildpack id is stillpaketo-buildpacks/bellsoft-liberica, like if you are making your own custom packages of a buildpack. In this case, to find the correct buildpack id the code will take the laste part of the package id, i.e.bellsoft-libericaand the indicated version, look through buildpack.toml and see if there is a match where some buildpack id ends with last part of the package id and has a matching version. If it locates a fuzzy match, the well use that id. If not, it fails.Use Cases
Checklist