Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable setting two dependency ids #402

Merged
merged 1 commit into from
Oct 7, 2021
Merged

Enable setting two dependency ids #402

merged 1 commit into from
Oct 7, 2021

Conversation

dmikusa
Copy link
Contributor

@dmikusa dmikusa commented Oct 7, 2021

Summary

During the update package dependency workflow, a dependency id is required. This is used to update both the buildpack.toml and package.toml. However, the id is not always the same in both files. By default, the workflow will use the DEPENDENCY variable for both. You can however also set one of BP_DEPENDENCY or PKG_DEPENDENCY. Do not set both! You need to set DEPENDENCY and this is where the workflow will obtain the new version (it looks at the image referenced by the id, like gcr.io/paketo-buildpacks/bellsoft-liberica). You can then set the variable for the value which differs from DEPENDENCY. Typically, this will be BP_DEPENDENCY as the package.toml file uses the full image name in it where buildpack.toml has the buildpack id name.

Use Cases

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

During the update package dependency workflow, a dependency id is required. This is used to update both the buildpack.toml and package.toml. However, the id is not always the same in both files. By default, the workflow will use the DEPENDENCY variable for both. You can however also set one of BP_DEPENDENCY or PKG_DEPENDENCY. Do not set both! You need to set DEPENDENCY and this is where the workflow will obtain the new version (it looks at the image referenced by the id, like gcr.io/paketo-buildpacks/bellsoft-liberica). You can then set the variable for the value which differs from DEPENDENCY. Typically, this will be BP_DEPENDENCY as the package.toml file uses the full image name in it where buildpack.toml has the buildpack id name.

Signed-off-by: Daniel Mikusa <[email protected]>
@dmikusa dmikusa added type:bug A general bug semver:patch A change requiring a patch version bump labels Oct 7, 2021
@dmikusa dmikusa requested a review from a team October 7, 2021 17:54
@dmikusa dmikusa merged commit 39bc645 into main Oct 7, 2021
@dmikusa dmikusa deleted the dependency-ids branch October 7, 2021 18:11
This was referenced Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:patch A change requiring a patch version bump type:bug A general bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant