Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify tools installation & pipelines #1490

Merged
merged 3 commits into from
Feb 21, 2024
Merged

Simplify tools installation & pipelines #1490

merged 3 commits into from
Feb 21, 2024

Conversation

dmikusa
Copy link
Contributor

@dmikusa dmikusa commented Feb 21, 2024 •
edited
Loading

Summary

  • Removes install-crane.sh, install-pack.sh and install-yj.sh
  • Switch from using custom install scripts to using buildpacks/github-actions
  • Remove usage of deprecated packages likeioutil

Use Cases

Pipeline clean up and simplification.

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@dmikusa
Simplify tools installation
ae177b9 
- Removes `install-crane.sh`, `install-pack.sh` and `install-yj.sh`
- Switch from using custom install scripts to using `buildpacks/github-actions`

Signed-off-by: Daniel Mikusa <[email protected]>
@dmikusa dmikusa added type:task A general task semver:patch A change requiring a patch version bump labels Feb 21, 2024
@dmikusa dmikusa requested a review from a team as a code owner February 21, 2024 04:22
@dmikusa
Remove deprecated code
b05a3ae 
Signed-off-by: Daniel Mikusa <[email protected]>
@dmikusa
Copy link
Contributor Author

dmikusa commented Feb 21, 2024

Tested with pipeline-builder-canary and all looks good.

anthonydahanne
anthonydahanne reviewed Feb 21, 2024
View reviewed changes
cmd/statik/main.go Outdated Show resolved Hide resolved
octo/builder_dependencies.go Show resolved Hide resolved
buildpack/rewriteLayer.go Show resolved Hide resolved
dmikusa
dmikusa commented Feb 21, 2024
View reviewed changes
cmd/statik/main.go Outdated Show resolved Hide resolved
dmikusa
dmikusa commented Feb 21, 2024
View reviewed changes
cmd/statik/main.go Outdated Show resolved Hide resolved
@anthonydahanne anthonydahanne merged commit 73e9a0c into main Feb 21, 2024
6 checks passed
@anthonydahanne anthonydahanne deleted the remove-install branch February 21, 2024 21:35
This was referenced Feb 28, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Feb 28, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Feb 29, 2024
Merged
Merged
This was referenced Feb 29, 2024
Merged
Merged
This was referenced Mar 5, 2024
Merged
Closed
@jorjazo jorjazo mentioned this pull request Feb 29, 2024
Open
@garethjevans garethjevans mentioned this pull request Feb 29, 2024
Open
This was referenced Mar 21, 2024
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anthonydahanne anthonydahanne anthonydahanne approved these changes

Assignees
No one assigned
Labels
semver:patch A change requiring a patch version bump type:task A general task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dmikusa @anthonydahanne