Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix detecting the old version #1447

Merged
merged 1 commit into from
Jan 23, 2024
Merged

Fix detecting the old version #1447

merged 1 commit into from
Jan 23, 2024

Conversation

dmikusa
Copy link
Contributor

@dmikusa dmikusa commented Jan 23, 2024

Summary

There are some PRs with no old version listed. This is happening because the query to pull out the old version needs the architecture. The jq query to do this needs a little more logic, so adding some to do the following:

  1. If no arch is set default to amd64 (handles the case where the buildpack doesn't provide this in the PURL but it is arch specific, this goes away long term).
  2. Try to find a dependency with this version and the arch set or the default arch.
  3. If no dependency is found then search with the version but no arch (handles the case where no arch is actually correct).

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

Signed-off-by: Daniel Mikusa <[email protected]>
@dmikusa dmikusa added type:bug A general bug semver:patch A change requiring a patch version bump labels Jan 23, 2024
@dmikusa dmikusa requested a review from a team as a code owner January 23, 2024 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:patch A change requiring a patch version bump type:bug A general bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants