Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump peter-evans/create-pull-request from 4 to 5 #1086

Labels
hacktoberfest Hacktoberfest eligible note:good-first-issue A good first issue to get started with note:ideal-for-contribution An issue that a contributor can help us with type:bug A general bug

Comments

@dmikusa
Copy link
Contributor

dmikusa commented Apr 5, 2023

Review release notes to see what has changed with this major bump. Evaluate if it is OK to bump for buildpacks.

See paketo-buildpacks/java-azure#852

@dmikusa dmikusa added type:bug A general bug note:good-first-issue A good first issue to get started with note:ideal-for-contribution An issue that a contributor can help us with labels Apr 5, 2023
@dmikusa
Copy link
Contributor Author

dmikusa commented Apr 6, 2023

and if possible also bump Bump mheap/github-action-required-labels from 3 to 4

@dmikusa
Copy link
Contributor Author

dmikusa commented Apr 7, 2023

https://github.com/mheap/github-action-required-labels/releases/tag/v4.0.0 -> Looks OK to me. Nothing jumps out as breaking.

https://github.com/peter-evans/create-pull-request/releases/tag/v5.0.0 -> Looks ok, but I'm not certain exact what the two documented breaking changes will mean.

  • The action will no longer leave the local repository checked out on the pull request branch. Instead, it will leave the repository checked out on the branch or commit that it was when the action started.
  • When using add-paths, uncommitted changes will no longer be destroyed. They will be stashed and restored at the end of the action run.

I don't think either of these will impact us, but I recommend that we apply this to pipeline-builder-canary first to confirm.

dmikusa added a commit that referenced this issue Apr 7, 2023
Bumps peter-evans/create-pull-request and mheap/github-action-required-labels to their latest major versions.

Signed-off-by: Daniel Mikusa <[email protected]>
This was referenced Apr 10, 2023
@anthonydahanne anthonydahanne added the hacktoberfest Hacktoberfest eligible label Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment