Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run dependency tests on bionic and jammy #296

Conversation

joshuatcasey
Copy link
Contributor

Summary

Run the dependency tests on a docker image (either bionic or jammy) so that the dynamic SSL linking can be verified.

Use Cases

Note that this is not exactly running the tests on the minimal stack image as per paketo-buildpacks/github-config#596 (comment), but it's a good start. We'll probably introduce some workflow changes in this area soon, so I don't think it's necessary to wait for a more full solution.

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@joshuatcasey joshuatcasey requested a review from a team as a code owner October 31, 2022 20:28
@joshuatcasey joshuatcasey added the semver:patch A change requiring a patch version bump label Oct 31, 2022
@joshuatcasey joshuatcasey self-assigned this Oct 31, 2022
@sophiewigmore
Copy link
Member

@joshuatcasey did you get a chance to run the workflow on this branch and see if it worked?

@joshuatcasey
Copy link
Contributor Author

@sophiewigmore I can't run actions due to permissions.

I did compile+test both bionic and jammy locally and that was successful.

@sophiewigmore
Copy link
Member

Alright, I'll run it just to see if it works in the workflow.
In the future, I think I'd prefer to see the action in the dependency/actions/test directory for consistency's sake but I think that'll require changes to the RFCs.

@sophiewigmore
Copy link
Member

Ah, can't run it because its a fork PR.

@sophiewigmore
Copy link
Member

let's merge it in and see if it works - looks reasonable.

@sophiewigmore sophiewigmore merged commit 6bcb2f5 into paketo-buildpacks:main Oct 31, 2022
@joshuatcasey joshuatcasey deleted the jtc/run-dep-tests-on-bionic-jammy branch October 31, 2022 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:patch A change requiring a patch version bump
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants