-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes #55 #57
Closes #55 #57
Conversation
|
8c26922
to
dfc0495
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't try running yet, but one request based on a quick read-through of the changes. It looks like you modified the existing test case to check for both files. Would you be able to make two separate test cases?
I'd prefer if the existing test case remains the same & an additional test case is added validating the new scenario. That way we're validating both cases, i.e. where a.) just a settings.xml is provided and b.) both settings.xml and settings-security.xml are provided.
@dmikusa-pivotal thanks for your suggestion. I've reverted now the original test case and added a second one as you proposed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Unit tests pass for me. Changed a few things and they broke as expected. Tested some builds with and without a security file. All worked as expected. Thanks for the PR!
Github is giving me issues merging. As soon as these clear up, I will merge this. Sorry for the delay. |
No worries, thank you for your quick operation! |
Just one more question: what's the release cycle of this buildpack? |
We don't have a time-based release cycle, it's more or less when there's something to release, we'll cut a new release. We are trying to iterate fast and get new features out quickly. I'll release this one today. It'll take a little time to get picked up by the paketo-buildpacks/java buildpack & the builder (maybe a day or two). You can use it directly in the meantime with Hope that helps! |
Summary
Add support for encrypted maven credentials.
Use Case
Usage of encrypted maven credentials (
settings.xml
plussettings-security.xml
).Checklist