Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use batch mode by default #45

Closed

Conversation

anthonydahanne
Copy link
Member

  • maven is very verbose in CI if you don't use this option

Summary

The batch mode option fits very well with CI tooling

Use Cases

Take this build for example:

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have reviewed the styleguide for guidance on my code quality.

* maven is very verbose in CI if you don't use this option
@anthonydahanne anthonydahanne requested a review from a team February 25, 2021 00:41
@ekcasey
Copy link
Member

ekcasey commented Feb 25, 2021

@anthonydahanne This makes sense. But I wonder if we want to append --batch-mode to the arguments only if stdout is not a tty? There may be cases where output is written to an actual TTY device and it would be nice to see progress bars and colors.

Related:

@ekcasey ekcasey added semver:minor A change requiring a minor version bump type:enhancement A general enhancement labels Feb 25, 2021
@anthonydahanne
Copy link
Member Author

oh indeed, that's a good idea to detect the stdout type!
héhé - buildpacks are all about detection !

anthonydahanne added a commit to anthonydahanne/maven that referenced this pull request Feb 25, 2021
anthonydahanne added a commit to anthonydahanne/maven that referenced this pull request Feb 25, 2021
anthonydahanne added a commit to anthonydahanne/maven that referenced this pull request Feb 25, 2021
anthonydahanne added a commit to anthonydahanne/maven that referenced this pull request Feb 26, 2021
anthonydahanne added a commit to anthonydahanne/maven that referenced this pull request Feb 26, 2021
anthonydahanne added a commit to anthonydahanne/maven that referenced this pull request Feb 27, 2021
anthonydahanne added a commit to anthonydahanne/maven that referenced this pull request Feb 27, 2021
anthonydahanne added a commit to anthonydahanne/maven that referenced this pull request Feb 27, 2021
@ekcasey ekcasey closed this in 30d5dda Mar 9, 2021
ekcasey added a commit that referenced this pull request Mar 9, 2021
Fix #45: Detect if batch-mode should be used
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:minor A change requiring a minor version bump type:enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants