-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use batch mode by default #45
Closed
anthonydahanne
wants to merge
1
commit into
paketo-buildpacks:main
from
anthonydahanne:use-batch-mode
Closed
Use batch mode by default #45
anthonydahanne
wants to merge
1
commit into
paketo-buildpacks:main
from
anthonydahanne:use-batch-mode
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* maven is very verbose in CI if you don't use this option
@anthonydahanne This makes sense. But I wonder if we want to append Related: |
ekcasey
added
semver:minor
A change requiring a minor version bump
type:enhancement
A general enhancement
labels
Feb 25, 2021
oh indeed, that's a good idea to detect the stdout type! |
anthonydahanne
added a commit
to anthonydahanne/maven
that referenced
this pull request
Feb 25, 2021
anthonydahanne
added a commit
to anthonydahanne/maven
that referenced
this pull request
Feb 25, 2021
anthonydahanne
added a commit
to anthonydahanne/maven
that referenced
this pull request
Feb 25, 2021
anthonydahanne
added a commit
to anthonydahanne/maven
that referenced
this pull request
Feb 26, 2021
anthonydahanne
added a commit
to anthonydahanne/maven
that referenced
this pull request
Feb 26, 2021
anthonydahanne
added a commit
to anthonydahanne/maven
that referenced
this pull request
Feb 27, 2021
anthonydahanne
added a commit
to anthonydahanne/maven
that referenced
this pull request
Feb 27, 2021
anthonydahanne
added a commit
to anthonydahanne/maven
that referenced
this pull request
Feb 27, 2021
ekcasey
added a commit
that referenced
this pull request
Mar 9, 2021
Fix #45: Detect if batch-mode should be used
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The batch mode option fits very well with CI tooling
Use Cases
Take this build for example:
Without batch mode, super verbose, for no added value:
https://github.com/anthonydahanne/java-applications-containerized/runs/1975032196
With batch mode, much more concise
https://github.com/anthonydahanne/java-applications-containerized/runs/1975054421
Checklist