Maven Logic Improvements #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If Maven was not in the buildplan, then the command would never be set. This means the case where Maven is provided externally would never work. The adjusted logic will unconditionally run the NoopMavenManger when maven is not in the buildplan. This will try to find Maven on the PATH. If it cannot find it on the path, then you get a reasonable error. Signed-off-by: Daniel Mikusa <[email protected]>
There was a bug with the detect logic where the Maven buildpack was providing 'jvm-application-package' without any requirements. This paired with executable-jar and the application server buildpacks which had a requirement of 'jvm-application-package' and created a successful buildplan when there shouldn't have been one. This was originally added to support the case where someone might want to perform a build but not have the buildpack install Maven. This PR changes the detection logic so that the 'jvm-application' is only added if a pom.xml file exists. This limits the functionality a bit, as you can only do a build-only build if you have a pom.xml but that seems reasonable at this time. If necessary, we could circle back and adjust the logic further, but the plan is to hold off until there is a more defined used case that would require this functionality. Additionally, this PR converts ioutil usage which has been deprecated. Signed-off-by: Daniel Mikusa <[email protected]>
dmikusa
added
type:bug
pivotal-david-osullivan
approved these changes
Oct 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This fixes a couple bugs:
Resolves #194
Use Cases
Fix bugs.
Checklist