Adjust detect logic for WAR/JAR files #189
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adjusts the detection logic so that it'll work with WAR/JAR files as well as building from source. It looks to see if the
META-INF/MANIFEST.MF
file exists in the application root, which it will for a WAR/JAR, and if so detection fails fast (failing is OK because the buildpack is optional in the buildplan).When building from source, this won't change any of the logic. There should not be a
META-INF/MANIFEST.MF
file when building from source.Use Cases
PR #185 had an issue which caused problems when building from a WAR/JAR file.
Checklist