Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust detect logic for WAR/JAR files #189

Merged
merged 1 commit into from
Sep 29, 2022
Merged

Conversation

dmikusa
Copy link
Contributor

@dmikusa dmikusa commented Sep 27, 2022

Summary

This PR adjusts the detection logic so that it'll work with WAR/JAR files as well as building from source. It looks to see if the META-INF/MANIFEST.MF file exists in the application root, which it will for a WAR/JAR, and if so detection fails fast (failing is OK because the buildpack is optional in the buildplan).

When building from source, this won't change any of the logic. There should not be a META-INF/MANIFEST.MF file when building from source.

Use Cases

PR #185 had an issue which caused problems when building from a WAR/JAR file.

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

PR [#185](#185) had an issue which caused problems when building from a WAR/JAR file. This PR adjusts the detection logic so that it'll work with WAR/JAR files as well as building from source.

Signed-off-by: Daniel Mikusa <[email protected]>
@dmikusa dmikusa added type:bug A general bug semver:patch A change requiring a patch version bump labels Sep 27, 2022
@dmikusa dmikusa requested a review from a team September 27, 2022 02:17
@dmikusa dmikusa mentioned this pull request Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:patch A change requiring a patch version bump type:bug A general bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants