-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maven dep #185
Commits on Sep 17, 2022
-
Move installation of Maven into it's own method
Signed-off-by: Daniel Mikusa <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 9750fa8 - Browse repository at this point
Copy the full SHA 9750fa8View commit details -
Move setup of Maven into separate method
Signed-off-by: Daniel Mikusa <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 14c4aef - Browse repository at this point
Copy the full SHA 14c4aefView commit details -
1. By default, we now pass 2. By default, we provide three possible plans all of which only provide (one provides just maven, one provides just a built app, one provides maven and a built app) 3. If a pom.xml file exists, then we add a requires (jdk, syft, maven). This enables more scenarios: 1. All we do is install Maven. In this case, the build plan will provide maven and some other build pack will need to require it. 2. All we do is build with Maven. In this case, something else needs to provide maven & jdk. 3. Both install and build with Maven. This the classic case that we've been supporting. Signed-off-by: Daniel Mikusa <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 0fc5c54 - Browse repository at this point
Copy the full SHA 0fc5c54View commit details -
Configurable install & build support
Based on what is in the buildplan, the buildpack can now optionally install and optionally build. If `maven` is in the buildplan, then the buildpack will attempt to install or validate that Maven is installed and generate a command to run Maven. This comes in four forms: 1. Install Maven Daemon 2. Install Maven 3. Validate Maven Wrapper 4. Validate Maven on $PATH If `jvm-application-package` is in the buildplan, then the buildpack will attempt to perform a build with Maven. This uses the command from the previously installed or validated Maven. This enables four scenarios: 1. The buildpack installs & runs Maven (or Maven Daemon) 2. The buildpack runs Maven w/Maven Wrapper 2. The buildpack just installs Maven (or Maven Daemon) 3. The buildpack doesn't install Maven or use Maven Wrapper, but just runs Maven (Maven is provided through other means) Signed-off-by: Daniel Mikusa <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 8379419 - Browse repository at this point
Copy the full SHA 8379419View commit details -
Updates README with changes to detect/build
Signed-off-by: Daniel Mikusa <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 30d2bca - Browse repository at this point
Copy the full SHA 30d2bcaView commit details
Commits on Sep 20, 2022
-
Configuration menu - View commit details
-
Copy full SHA for bba336f - Browse repository at this point
Copy the full SHA bba336fView commit details -
- Added a case for default pom.xml location as well as a custom location when the file does not exist - Fixed descriptions & added context for additional grouping Signed-off-by: Daniel Mikusa <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 2657ee8 - Browse repository at this point
Copy the full SHA 2657ee8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6326544 - Browse repository at this point
Copy the full SHA 6326544View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.