Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proceed with warning if there's no WRITE access to mvnw #151

Merged
merged 1 commit into from
Jun 7, 2022

Conversation

cz4rny
Copy link
Contributor

@cz4rny cz4rny commented Jun 7, 2022

Summary

Fixes #150

Use Cases

When running on GitLab the checkout code is not writable for a moment. At that time one cannot modify the mvnw.

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@cz4rny cz4rny requested a review from a team June 7, 2022 08:40
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jun 7, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

@dmikusa dmikusa added type:bug A general bug semver:patch A change requiring a patch version bump labels Jun 7, 2022
@dmikusa dmikusa merged commit 6e89103 into paketo-buildpacks:main Jun 7, 2022
@cz4rny cz4rny deleted the dont-fail-on-chmod-mvnw branch June 8, 2022 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:patch A change requiring a patch version bump type:bug A general bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chmod of mvnw causes GitLab CI build to fail
2 participants