Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new metadata struct for dependency metadata #312

Draft
wants to merge 1 commit into
base: release-2.x
Choose a base branch
from

Conversation

c0d1ngm0nk3y
Copy link
Contributor

@c0d1ngm0nk3y c0d1ngm0nk3y commented Aug 1, 2023

needs paketo-buildpacks/libpak#283 (libpak v2)

Summary

Use the newly introduced DependencyLayerContributorMetadata as metadata rather than the whole dependency.

Use Cases

Using the complete dependency for using reflect.DeepEqual has sometimes strange results and even lead to very specific coding in libpak. This would simplify things.

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@c0d1ngm0nk3y
Copy link
Contributor Author

Since this requires libpak v2, we will have to wait...

@dmikusa
Copy link
Contributor

dmikusa commented Oct 27, 2023

If you want to rebase this against https://github.com/paketo-buildpacks/libjvm/tree/release-2.x we could move this forward.

@c0d1ngm0nk3y c0d1ngm0nk3y changed the base branch from main to release-2.x October 30, 2023 07:50
@c0d1ngm0nk3y
Copy link
Contributor Author

If you want to rebase this against https://github.com/paketo-buildpacks/libjvm/tree/release-2.x we could move this forward.

It still needs the latest changes to be released, but at least it is already on the right base branch.

@c0d1ngm0nk3y
Copy link
Contributor Author

@dmikusa Do you know what the plan for v2@libpak is?

@dmikusa
Copy link
Contributor

dmikusa commented Feb 2, 2024

It needs a bunch of work, I think there are some stories tagged as v2. It also just needs someone to go through and do updates like removing ioutil, switching to use t.Setenv and other clean up. I think there's probably also some of the structures that we want to rethink. There have been some pain points, some parts of the code that have grown a little tricky to manage and this v2 is a chance to revisit those and see if we can improve the situation.

I haven't personally had much time to work on it, as I've been focused on the ARM64 efforts. When we get that shipped, I will probably try to circle back to this. I don't think there's a huge rush to get v2 released, but it is a bit of a pain since we're maintaining both v1 and v2 for the time being.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants