Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconcile multi arch support for push-image workflow #984

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

pacostas
Copy link
Contributor

@pacostas pacostas commented Oct 8, 2024

Summary

This PR reconciles the implementation of push-image workflow for a single architecture with the multi-arch one that currently exists on jammy-tiny-stack.

  • It does not change any of the current functionality of the stacks while pushing to the registry. It only extends the current functionality to support pushing multiarch images to the registry.

In addition to the changes on push-image.yml workflow, this PR introduces an extra script called publish.sh, which is able to push multiple architectures to the registry and not only a single one. The publish.sh script is based on the multi-arch implementation script that exists on jammy-tiny-stack https://github.com/paketo-buildpacks/jammy-tiny-stack/blob/main/scripts/publish.sh. In addition, extra functionality to the publish.sh script has been added to push one image per time instead of two (build and run images = stack), as jam now supports the publish-image argument. This enables faster push to image registries (in push-image workflow) due to job parallelization, less code on the push-image workflow as the same action is used for the build and the run image, a more generic approach to support ubi scenarios where the build image is not used/pushed in most of the stacks.

This PR has been tested to push the images properly to the registries. Test results :

Use Cases

  • Multi and single architecture support for the push-image workflow, without breaking the existing functionality.

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@pacostas pacostas force-pushed the multi-arch-stack-push-image branch from 44b9a94 to 077cd39 Compare November 1, 2024 10:48
@pacostas pacostas marked this pull request as ready for review November 1, 2024 10:49
@pacostas pacostas requested a review from a team as a code owner November 1, 2024 10:49
@pacostas
Copy link
Contributor Author

pacostas commented Nov 1, 2024

@ForestEckhardt

@pacostas pacostas force-pushed the multi-arch-stack-push-image branch from 556fef6 to ee22bf1 Compare December 16, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant