Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting up local registry functionality #955

Merged
merged 3 commits into from
Jul 1, 2024

Conversation

pacostas
Copy link
Contributor

@pacostas pacostas commented Jun 25, 2024

Summary

This pull request adds to test.sh the option to set up a local registry with crane. Specifically if a file called integration.json exists and it has an attribute called "setup_local_registy": true in it, then, the test.sh script will spawn a local registry on a random available port and export the registry url to an env variable called REGISTRY_URL to make it available for any program that might need to use it. After test.sh has finished, the local registry is being killed.

This is useful for two reasons:

The current implementation of creating a local registry has been copied over from the jammy-tiny-stack repo, with the only difference being that the create registry functionality has been moved to a commonplace, the to tools.sh file, as in the near future, it will be used by two scripts, the test.sh (which is currently used by the extension) and the receipts.sh (when the mutli-arch has been implemented for the stacks)

Testing

Use Cases

  • Extension needing a local registry to push the builder while running acceptance tests.

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@pacostas pacostas requested a review from a team as a code owner June 25, 2024 12:15
@pacostas pacostas marked this pull request as draft June 25, 2024 12:19
@pacostas pacostas marked this pull request as ready for review June 25, 2024 12:50
robdimsdale
robdimsdale previously approved these changes Jun 26, 2024
stack/scripts/test.sh Outdated Show resolved Hide resolved
stack/scripts/test.sh Outdated Show resolved Hide resolved
@ForestEckhardt ForestEckhardt enabled auto-merge (rebase) July 1, 2024 18:20
@ForestEckhardt ForestEckhardt merged commit 9dab3d7 into paketo-buildpacks:main Jul 1, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants