Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stack - Select on which registries to push stack images #950

Merged

Conversation

pacostas
Copy link
Contributor

Summary

This PR adds an extra option, which specifies on which registries the stack should push. Specifically, if on the root directory of the implementation, there is a file called registries.json with the below content

{
  "dockerhub": true,
  "GCR": false
}

it means that the action will push the stack images to dockerhub but NOT to GCR.

In case the registries.json file does not exist, it fallbacks to the current behavior which is to push on both registries.

In case where an attribute is NOT specified, then the default value is true.

Use Cases

This is useful for projects being under paketo-community organization, where GCR is not available.

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@pacostas pacostas requested a review from a team as a code owner June 18, 2024 15:10
@pacostas
Copy link
Contributor Author

@mhdawson @ForestEckhardt

@pacostas pacostas changed the title Stack: Select on which registries to push stack images Stack - Select on which registries to push stack images Jun 18, 2024
Copy link
Member

@robdimsdale robdimsdale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, with one minor question (inline) about potentially duplicated lines.

stack/.github/workflows/push-image.yml Outdated Show resolved Hide resolved
@pacostas pacostas force-pushed the stack-push-image-conditionaly branch from 6930491 to 29c9f2d Compare July 2, 2024 12:55
@pacostas
Copy link
Contributor Author

pacostas commented Jul 2, 2024

@ForestEckhardt @robdimsdale I think this PR is ready to be landed.

@ForestEckhardt ForestEckhardt merged commit 071da6a into paketo-buildpacks:main Jul 2, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants