Generating dockerhub org name according to github repo owner #888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 19, 2024
Comment on lines
43
to
44
| # Strip off the Github org prefix from repo name | ||
| # paketo-buildpacks/builder-with-some-name --> builder-with-some-name |
There was a problem hiding this comment.
nitpick: can we keep the comments for the registry_repo line?
There was a problem hiding this comment.
yeap, I reverted the comment back :)
sophiewigmore
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds functionality for generating Dockerhub org variable based on the repository owner name. E.x. instead of having
DOCKERHUB_ORGenv variable pinned to valuepaketobuildpackswe fetch the repository ownerpaketo-buildpacksorpaketo-communityand we remove the-to match the dockerhub org name. This change is helpful as repositories under the paketo-community organization can now sync thepush-image.ymlfileUse Cases
Checklist