Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop requiring .NET runtime / ASP.NET during build #330

Merged
merged 3 commits into from
Jul 14, 2022
Merged

Stop requiring .NET runtime / ASP.NET during build #330

merged 3 commits into from
Jul 14, 2022

Conversation

sophiewigmore
Copy link
Member

@sophiewigmore sophiewigmore commented Jul 7, 2022 •
edited
Loading

Summary

Part of paketo-buildpacks/dotnet-core#722

Use Cases

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

Stop requiring .NET runtime / ASP.NET during build
61b5f7b 
- New SDK dependency includes runtime and ASP.NET
- Require a specific version of SDK specified in project file
- Add project file version parser by @fg-j
- Remove ASP.NET parser
@sophiewigmore sophiewigmore self-assigned this Jul 7, 2022
@sophiewigmore sophiewigmore added the semver:minor A change requiring a minor version bump label Jul 7, 2022
@sophiewigmore
Copy link
Member Author

Minor release due to a change in the requires

@sophiewigmore sophiewigmore marked this pull request as ready for review July 8, 2022 13:30
@sophiewigmore sophiewigmore requested a review from a team as a code owner July 8, 2022 13:30
@fg-j fg-j merged commit b9b64ba into main Jul 14, 2022
@fg-j fg-j deleted the sw-patch-1 branch July 14, 2022 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fg-j fg-j fg-j approved these changes

@ForestEckhardt ForestEckhardt Awaiting requested review from ForestEckhardt ForestEckhardt is a code owner automatically assigned from paketo-buildpacks/dotnet-core-maintainers

Assignees

@sophiewigmore sophiewigmore

Labels
semver:minor A change requiring a minor version bump
Projects
Paketo Workstreams
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sophiewigmore @fg-j