Skip to content
This repository has been archived by the owner on Jan 27, 2023. It is now read-only.

Don't set DOTNET_ROOT during build #347

Merged
merged 3 commits into from
Jul 14, 2022
Merged

Don't set DOTNET_ROOT during build #347

merged 3 commits into from
Jul 14, 2022

Conversation

sophiewigmore
Copy link
Member

Summary

As a part of paketo-buildpacks/dotnet-core#722, the .NET Core ASP.NET buildpack will no longer be needed during build, so there's no need to make the DOTNET_ROOT available at build-time anymore.

Use Cases

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@sophiewigmore sophiewigmore added the semver:patch A change requiring a patch version bump label Jul 7, 2022
@sophiewigmore sophiewigmore self-assigned this Jul 7, 2022
@sophiewigmore sophiewigmore marked this pull request as ready for review July 8, 2022 13:28
@sophiewigmore sophiewigmore requested a review from a team as a code owner July 8, 2022 13:28
@sophiewigmore
Copy link
Member Author

This should probably get merged in after the related SDK and Publish PRs.

@fg-j fg-j enabled auto-merge (squash) July 14, 2022 21:13
@fg-j fg-j added semver:minor A change requiring a minor version bump and removed semver:patch A change requiring a patch version bump labels Jul 14, 2022
@fg-j fg-j merged commit 4ecffb0 into main Jul 14, 2022
@fg-j fg-j deleted the sw-patch-1 branch July 14, 2022 21:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
semver:minor A change requiring a minor version bump
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants