Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updater is picking the wrong binary #322

Closed
dmikusa opened this issue May 5, 2023 · 1 comment · Fixed by paketo-buildpacks/pipeline-builder#1168
Closed

Updater is picking the wrong binary #322

dmikusa opened this issue May 5, 2023 · 1 comment · Fixed by paketo-buildpacks/pipeline-builder#1168
Labels
hacktoberfest Hacktoberfest eligible note:good-first-issue A good first issue to get started with note:ideal-for-contribution An issue that a contributor can help us with type:bug A general bug

Comments

@dmikusa
Copy link
Contributor

dmikusa commented May 5, 2023

Expected Behavior

We ship a standard Azul JDK.

Current Behavior

The updater is picking Azul's JDK with crac in it for Java 17.

See this PR: https://github.com/paketo-buildpacks/azul-zulu/pull/321/files#diff-5f54cb49d0e28117084fad482c0daf89502d4ecb329230071fcf78e56dc939b3R204

Possible Solution

Fix the updater action so it picks the right version: https://github.com/paketo-buildpacks/pipeline-builder/blob/main/actions/azul-zulu-dependency/main.go

@dmikusa dmikusa added type:bug A general bug note:good-first-issue A good first issue to get started with note:ideal-for-contribution An issue that a contributor can help us with labels May 5, 2023
@anthonydahanne
Copy link
Member

yes, I confirm,
https://api.azul.com/zulu/download/community/v1.0/bundles/latest/?arch=x86&ext=tar.gz&hw_bitness=64&os=linux&javafx=false&features=jdk&jdk_version=17
returns a crac version

But I think the focus of this issue should rather be on adopting Azul Zulu new metadata API, as documented here: https://docs.azul.com/core/metadata-api-migration.html that replaces the former download API.

In that case, that's the URL that should be sent by our updater:
https://api.azul.com/metadata/v1/zulu/packages/?java_version=17&os=linux-glibc&arch=amd64&java_package_type=jdk&javafx_bundled=false&release_status=ga&availability_types=CA&certifications=tck&page=1&crac_supported=false&archive_type=tar.gz&latest=true

dmikusa added a commit to paketo-buildpacks/pipeline-builder that referenced this issue Jun 8, 2023
This commit switches from the old Discovery API to using the Metadata API. This also resolves issue paketo-buildpacks/azul-zulu#322.

Signed-off-by: Daniel Mikusa <[email protected]>
@anthonydahanne anthonydahanne added the hacktoberfest Hacktoberfest eligible label Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest Hacktoberfest eligible note:good-first-issue A good first issue to get started with note:ideal-for-contribution An issue that a contributor can help us with type:bug A general bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants