Fix shellcheck issues in add-classpath-entries.sh

tomcat/add-classpath-entries.sh

@@ -1,7 +1,10 @@
 #!/bin/sh
-
+set -e
 mkdir -p "{{.libDir}}"
-while IFS=: read -d: -r path; do
-    printf "Linking $path to '{{.libDir}}/$(basename $path)'\n"
-    ln -s "$path" "{{.libDir}}/$(basename $path)"
-done <<< "${CLASSPATH}"
+(
+    IFS=:
+    for path in $(printf '%s' "$CLASSPATH"); do
+        printf "Linking %s to '{{.libDir}}/$(basename "$path")'\n" "$path"
+        ln -s "$path" "{{.libDir}}/$(basename "$path")"
+    done
+)

tomcat/base.go

@@ -301,7 +301,7 @@ func (b Base) ContributeLogging(layer libcnb.Layer) error {
 func (b Base) ContributeClasspathEntries(layer libcnb.Layer) error {
 	b.Logger.Bodyf("Adding profile-script 'add-classpath-entries.sh'")
 
-	libDir := fmt.Sprintf("%s/lib", layer.Path)
+	libDir := filepath.Join(layer.Path, "lib")
 	s, err := sherpa.TemplateFile("/add-classpath-entries.sh", map[string]interface{}{"libDir": libDir})
 	if err != nil {
 		return fmt.Errorf("unable to load add-classpath-entries.sh\n%w", err)

tomcat/base_test.go

@@ -112,12 +112,15 @@ export JAVA_OPTS="${JAVA_OPTS} -Daccess.logging.enabled=true"
 `))
 		libDir := filepath.Join(layer.Path, "lib")
 		Expect(layer.Profile["add-classpath-entries.sh"]).To(Equal(fmt.Sprintf(`#!/bin/sh
-
+set -e
 mkdir -p "%[1]s"
-while IFS=: read -d: -r path; do
-    printf "Linking $path to '%[1]v/$(basename $path)'\n"
-    ln -s "$path" "%[1]s/$(basename $path)"
-done <<< "${CLASSPATH}"
+(
+    IFS=:
+    for path in $(printf '%%s' "$CLASSPATH"); do
+        printf "Linking %%s to '%[1]s/$(basename "$path")'\n" "$path"
+        ln -s "$path" "%[1]s/$(basename "$path")"
+    done
+)
 `, libDir)))
 		Expect(filepath.Join(layer.Path, "lib", "stub-tomcat-lifecycle-support.jar")).To(BeARegularFile())
 		Expect(filepath.Join(layer.Path, "bin", "stub-tomcat-logging-support.jar")).To(BeARegularFile())