adding proxy url support for signing via header #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pakerfeldt
reviewed
Apr 1, 2020
| @@ -80,6 +80,9 @@ public String getMethod() { | |||
|
|
|||
| @Override | |||
| public String getRequestUrl() { | |||
| if (this.request.header("X-PROXY-CUSTOM-URL") != null) { | |||
There was a problem hiding this comment.
What kind of header is X-PROXY-CUSTOM-URL? Looks to be a custom proprietary header which this library should have no knowledge about.
There was a problem hiding this comment.
header name can be anything, gave this so that anyone using this library can use it.
There was a problem hiding this comment.
Via headers, we can pass information of actual service provider URLs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there is HTTP proxy (forward proxy) is present in the network, connects to the service provider domain, then your app has to use a proxy domain. For such cases, signing has to happen with the service provider domain, not with HTTP proxy domain.