Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX union calculation in hungarian_miou #7

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

JohannesTheo
Copy link
Contributor

Hey there, we found a small bug in the calculation of the union in the hungarian_miou method.

Your code uses addition instead of sum and logical_or which results in an upper bound of 0.5 for perfect predictions. For instance, if true_oh == pred_oh, the intersections are simply the sizes of the instances and so should the unions be as well. With the addition however, you count the instance sizes twice which results in the upper bound of 0.5 in this case. An easy fix is to subtract the intersection from this calculation.

Importantly, this bug is most likely only a scaling issue and should not change published results beyond this point.

Best, Johannes

@Wuziyi616
Copy link
Member

Thanks a lot for the fix! Yes, I agree the bug isn't likely to change the order of the benchmarked methods. I'll try to update the manuscript after re-running the evaluation.

@Wuziyi616
Copy link
Member

Hi, the new SlotFormer result is updated in PR#8 now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants