Updated commands and added module for colorful printable output. #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayurilahane
force-pushed
the
updated_commands
branch
from
67d390e to
c59a45b
Compare
ganeshhubale
suggested changes
Feb 11, 2020
| except sqlite3.IntegrityError: | ||
| print( | ||
| colored("Already exists with the same name. Try with another Portal_name", "green") | ||
| ) |
| self.email = email | ||
| self.portal_name = portal_name | ||
| self.portal_url = portal_url | ||
| self.cursor_obj.execute( |
There was a problem hiding this comment.
@mayurilahane Why do we need variable initialization inside the try block?
There was a problem hiding this comment.
yes, agree!
we can do this try where we are actually getting values.
thanks for suggesting!
|
Any updates on this PR @mayurilahane ? |
mayurilahane
force-pushed
the
updated_commands
branch
from
c59a45b to
aae5173
Compare
mayurilahane
changed the title
mayurilahane
changed the title
mayurilahane
added a commit
to mayurilahane/pygenpass
that referenced
this pull request
Jul 26, 2020
Updated commands and added module for colorful printable output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
please have a look @ganeshhubale @Yadnyawalkya