Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to ESM #427

Closed
wants to merge 2 commits into from
Closed

Migrate to ESM #427

wants to merge 2 commits into from

Conversation

vikingair
Copy link
Collaborator

  • Verify that the generated output is still fine
  • Check that inclusion of package still works when installed
  • Fix broken test "supports resolve root paths in webpack config"

@vikingair vikingair requested a review from pahen June 13, 2024 12:04
@vikingair
Copy link
Collaborator Author

@pahen This change was necessary in order to update some of the very outdated dependencies. Non-ESM projects will not be able to import "madge" anymore via "require". Hopefully, that is not a blocker, as CJS should be already abandoned by a large majority, especially as even more popular libs such as "chalk" have gone this path a long time ago.

What do you think?

And, do you have maybe an idea why the one remaining test might fail?

@vikingair
Copy link
Collaborator Author

@pahen Any feedback from your site? Before investing more time into the PR, I wanted to make sure you agree with this step.

@pahen
Copy link
Owner

pahen commented Aug 5, 2024

@pahen Any feedback from your site? Before investing more time into the PR, I wanted to make sure you agree with this step.

Note sure about this. The fact that non-ESM projects can't use madge is a big blocker to me.

@vikingair
Copy link
Collaborator Author

@pahen You are the decision maker. In that case, we will need to keep the long time outdated "chalk" dependency or replace it by e.g. picocolors.

What would you prefer?

@pahen
Copy link
Owner

pahen commented Aug 5, 2024

@pahen You are the decision maker. In that case, we will need to keep the long time outdated "chalk" dependency or replace it by e.g. picocolors.

What would you prefer?

Replacing chalk with picocolors sounds good to me if it provides the same functionally that madge uses.

@vikingair
Copy link
Collaborator Author

Will see when I can find the time :P

@vikingair vikingair closed this Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants