Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Run build & test scripts on GitHub Actions #394

Merged
merged 6 commits into from
Oct 24, 2023

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented Oct 22, 2023

  • Check in package-lock.json again (originally removed in 8fd1859)
    • lockfile v2 format for widest compatibility (npm@9 runs on >=14; can be upgraded when engines.node field in package.json is increased)
  • Add CI job triggered on pull requests:
    • run test, debug, generate scripts

Workflow run: https://github.com/legobeat/madge/actions/runs/6606937817/job/17943672753

@legobeat legobeat marked this pull request as ready for review October 22, 2023 23:40
@PabloLION
Copy link
Collaborator

Wow, this is amazing! I've been wanting to include CI into the workflow for a while. Thanks so much!

Copy link
Collaborator

@PabloLION PabloLION left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small question here.

.github/workflows/nodejs.yml Outdated Show resolved Hide resolved
@legobeat legobeat requested a review from PabloLION October 24, 2023 10:12
@legobeat
Copy link
Contributor Author

legobeat commented Oct 24, 2023

@PabloLION: You're welcome :)

I noticed the codecov step was incomplete, so I removed it. It can be added in separately after, if desired.

@PabloLION PabloLION merged commit 7ca8887 into pahen:master Oct 24, 2023
@PabloLION
Copy link
Collaborator

Also, just to mention, the old Travis CI at https://app.travis-ci.com/github/pahen/madge stopped working since February so this PR came just in time!
And since the old version had no code coverage check, we are at least not making it worse.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants