Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support package.json config #236

Merged
merged 2 commits into from
Jan 30, 2020
Merged

feat: support package.json config #236

merged 2 commits into from
Jan 30, 2020

Conversation

zekth
Copy link
Contributor

@zekth zekth commented Jan 28, 2020

fix #235

So this line is a bit ugly:

return require(path.join(process.cwd(), 'package.json')).madge;

But due to eslint i'm forced to do it because of the nosync rule. Making the fs lookup for the package.json async would wrap everything up into a promise; which involves more coding for not so much benefit.

Let me know your thoughts about it.

bin/cli.js Outdated Show resolved Hide resolved
@pahen pahen merged commit 0e8951f into pahen:master Jan 30, 2020
@pahen
Copy link
Owner

pahen commented Jan 30, 2020

Published in v3.7.0

@zekth zekth deleted the add-package-support branch January 30, 2020 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support package.json configuration
2 participants